[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should rebuild automatically when a new patch is pushed to master

[Addshore]

Addshore added a comment.

So, while trying to move this to blubber I hit the first issue.

$ docker run --rm -it wdqs-gui-test-$(date --iso)

> wikidata-query-gui@0.1.4 test /srv/service
> grunt test

>> Local Npm module "grunt-auto-install" not found. Is it installed?
>> Local Npm module "grunt-banana-checker" not found. Is it installed?
>> Local Npm module "grunt-contrib-clean" not found. Is it installed?
>> Local Npm module "grunt-contrib-concat" not found. Is it installed?
>> Local Npm module "grunt-contrib-copy" not found. Is it installed?
>> Local Npm module "grunt-contrib-cssmin" not found. Is it installed?
>> Local Npm module "grunt-contrib-htmlmin" not found. Is it installed?
>> Local Npm module "grunt-contrib-jshint" not found. Is it installed?
>> Local Npm module "grunt-contrib-less" not found. Is it installed?
>> Local Npm module "grunt-contrib-qunit" not found. Is it installed?
>> Local Npm module "grunt-contrib-uglify" not found. Is it installed?
>> Local Npm module "grunt-filerev" not found. Is it installed?
>> Local Npm module "grunt-jscs" not found. Is it installed?
>> Local Npm module "grunt-jsonlint" not found. Is it installed?
>> Local Npm module "grunt-merge-i18n" not found. Is it installed?
>> Local Npm module "grunt-shell" not found. Is it installed?
>> Local Npm module "grunt-stylelint" not found. Is it installed?
>> Local Npm module "grunt-usemin" not found. Is it installed?
Warning: Task "jshint" not found. Use --force to continue.

Aborted due to warnings.
npm ERR! Test failed.  See above for more details.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

It looks like this is due to the dockerfile generated by blubber doing the install of npm packages in one directory:

COPY --chown=65533:65533 ["package.json", "/opt/lib/"]
RUN cd "/opt/lib" && npm install

While having the project files in another dir

WORKDIR "/srv/service
.....
COPY --chown=65533:65533 [".", "."]

and apparently grunts require() method will always look for node_modules directory in the project dir, ignoring the ENV vars??

TASK DETAIL

https://phabricator.wikimedia.org/T192006

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: akosiaris, thcipriani, Addshore, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, Abbe98, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs