| Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE triaged this task as "Low" priority. Lucas_Werkmeister_WMDE added a project: Wikidata. |
In Ice7ac84b10, I added a browser test for adding a statement to a Wikibase item using the keyboard. On Beta, this fails, e. g. in this job:
16:17:43 [chrome #0-0] item 16:17:43 [chrome #0-0] 1) can add a statement using the keyboard 16:17:43 [chrome #0-0] 16:17:43 [chrome #0-0] 16:17:43 [chrome #0-0] 2 failing (7s) 16:17:43 [chrome #0-0] 16:17:43 [chrome #0-0] 1) item can add a statement using the keyboard: 16:17:43 [chrome #0-0] failed-save: The save has failed. 16:17:43 [chrome #0-0] Error: failed-save: The save has failed. 16:17:43 [chrome #0-0] at rawRequest.then (/src/node_modules/mwbot/src/index.js:257:31) 16:17:43 [chrome #0-0] at tryCatcher (/src/node_modules/bluebird/js/release/util.js:16:23) 16:17:43 [chrome #0-0] at Promise._settlePromiseFromHandler (/src/node_modules/bluebird/js/release/promise.js:512:31) 16:17:43 [chrome #0-0] at Promise._settlePromise (/src/node_modules/bluebird/js/release/promise.js:569:18) 16:17:43 [chrome #0-0] at Promise._settlePromise0 (/src/node_modules/bluebird/js/release/promise.js:614:10) 16:17:43 [chrome #0-0] at Promise._settlePromises (/src/node_modules/bluebird/js/release/promise.js:694:18) 16:17:43 [chrome #0-0] at _drainQueueStep (/src/node_modules/bluebird/js/release/async.js:138:12) 16:17:43 [chrome #0-0] at _drainQueue (/src/node_modules/bluebird/js/release/async.js:131:9) 16:17:43 [chrome #0-0] at Async._drainQueues (/src/node_modules/bluebird/js/release/async.js:147:5) 16:17:43 [chrome #0-0] at Immediate.Async.drainQueues (/src/node_modules/bluebird/js/release/async.js:17:14) 16:17:43 [chrome #0-0] at runCallback (timers.js:672:20) 16:17:43 [chrome #0-0] at tryOnImmediate (timers.js:645:5) 16:17:43 [chrome #0-0] at processImmediate [as _immediateCallback] (timers.js:617:5) 16:17:43 [chrome #0-0]
The reason is that anonymous users aren’t allowed to create properties on Beta, which the test attempts to do. Specifically, the test creates a new item to add the statement to, as well as a new property to use for the statement and its qualifiers and references. Neither of these is strictly necessary: the test works on existing items (even if they already have statements), and it could also use the ID of an existing property, provided that it has the 'string' datatype. ('external-id' should also work, and some others like 'url' could also be supported with minor changes to the test, but let’s keep it simple.)
It’s probably not a good idea to have an automatic test continuously add statements to an item – eventually, the item will exceed the maximum MediaWiki page size. But we should be able to change the test to optionally read a property ID from its environment, and only create a new property if that’s missing.
Cc: Aklapper, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
