| Umherirrender added a comment. |
In T208253#4705596, @hashar wrote:In T208253#4703946, @D3r1ck01 wrote:@hashar, loots of errors & warnings now: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/22738/console, my system doesn't run PHP 7.3 :( Maybe someone can take it from here? Invoking @Legoktm maybe?
I guess those errors are related to new rules added by codesniffer.
Legoktm stated on T208234 that mediawiki code sniffer 19+ does get support for PHP7.3. So we can trust his word and just assume it will be fixed. That can be checked in CI though by commenting check experimental on the change, that runs jobs using PHP7.3 (among other jobs).
19.1.0 is the fix for php 7.3, but wikibase codesniffer 0.5.0 does not use that version. So wikibase codesniffer needs also a minor release to pull in the minor release of mediawiki codesniffer to get the php 7.3 fix
Cc: Umherirrender, Legoktm, D3r1ck01, gerritbot, WMDE-leszek, thiemowmde, Aklapper, hashar, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, MGChecker, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
