| Mvolz added a comment. |
In T153685#4809614, @Jan_Dittrich wrote:Can the improvements be reviewed and merged back?
Theoretically yes :). You can open a pull request here: https://github.com/filbertkm/wikidata-citetool/pulls
Although this ticket actually conflicts with my own ideas about how the button should work. The button popping into existence when you select the type (doi/reference url) is bad UI; it should be grayed out and just be activated/enabled. However if we do it that way then having the title depend on the type selected (doi/reference url) doesn't work because the button will already exist before selection.
TASK DETAIL
EMAIL PREFERENCES
To: Mvolz
Cc: Mvolz, MichaelSchoenitzer, Charlie_WMDE, Lydia_Pintscher, aude, Aklapper, Jan_Dittrich, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, dachary, LawExplorer, _jensen, D3r1ck01, Shangkuanlc, mobrovac, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331
Cc: Mvolz, MichaelSchoenitzer, Charlie_WMDE, Lydia_Pintscher, aude, Aklapper, Jan_Dittrich, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, dachary, LawExplorer, _jensen, D3r1ck01, Shangkuanlc, mobrovac, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
