Tarrow added a comment.

As you can see in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/477790 attempting to complete this task by just wrapping the same widget we use for monolingual text had a few issues.

Attempting to follow the pattern for ItemSelectorWrapper which is used by LanguageAndLexicalCategoryWidget resulted in a working selector.

Specifically it is rather tricky to test well.

Indeed it appears that ItemSelectorWrapper isn't actually tested (other than by ruby browsertests) because the templates used in the tests are out of sync with the templates shipped by PHP (see: T198455).


TASK DETAIL
https://phabricator.wikimedia.org/T209931

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: gerritbot, Lea_Lacroix_WMDE, Lydia_Pintscher, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to