| Addshore added a comment. |
In T209504#4840623, @Lucas_Werkmeister_WMDE wrote:Well, none of those changes actually tell us if that’s a good thing or not, I think :) but the overall mean and median times for “type” and “value type” checks also went down noticeably, which is great.
That said, I’m still not sure if we shouldn’t increase the limit even further? Even now, type checks running into the limit are still much faster than SPARQL checks (roughly 20 vs. 140 ms).
There were not specific acceptance criteria so I was simply validating that "Perform more constraint type checks in PHP before falling back to SPARQL" had been done.
I also think we could increase the limit more.
TASK DETAIL
EMAIL PREFERENCES
To: Addshore
Cc: Addshore, Stashbot, Agabi10, gerritbot, Michael, Lucas_Werkmeister_WMDE, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
Cc: Addshore, Stashbot, Agabi10, gerritbot, Michael, Lucas_Werkmeister_WMDE, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
