Lucie created this task.
Lucie added subscribers: Aklapper, Lucie.
Lucie added projects: Wikidata, WikibaseQueryEngine.
Lucie changed Security from none to none.

TASK DESCRIPTION
  "Copy paste from 14#discussion_r11197176 by @thiemowmde:
  
  I do have the strong feeling that something is wrong here. Sorry, really not 
meant to be personal. I'm really curious and a bit terrified. Using a hash for 
sorting? Who does this? You can not use it for sorting anyway. It will be wrong 
after the first few characters.
  
  Now it's neither a valid hash nor a valid sorting information. What's the 
purpose of this thing?
  
  At least make $PLAIN_LENGTH = 10 and $SHA_LENGTH = 40. I would feel much more 
comfortable then.
  
  Relevant files:
  
    -     
https://github.com/wmde/WikibaseQueryEngine/blob/e6bae3266bc4b1e1e7e71599044fb0b1bd30169b/src/SQLStore/DVHandler/StringHandler.php
    -     
https://github.com/wmde/WikibaseQueryEngine/blob/e6bae3266bc4b1e1e7e71599044fb0b1bd30169b/src/StringHasher.php
  "
  
  https://github.com/wmde/WikibaseQueryEngine/issues/18

TASK DETAIL
  https://phabricator.wikimedia.org/T78666

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
<username>.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucie
Cc: Aklapper, Lucie, Wikidata-bugs, aude



_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to