Amire80 added a comment.

@Lydia_Pintscher , thanks a lot for asking! :)

The first example with the comma certainly looks better than the other ones with no separator.

As far as I can see, and as @Bugreporter has already written above, the message with the comma is implemented using the optional message wikibaselexeme-presentation-lexeme-secondary-label. It's default value is, expectedly $1, $2. It's a good default. I could imagine some other clever and more generic schemes, for example to use a | as a separator, but it's not really needed, and a comma is good enough. If anybody thinks that a comma is not good enough, I'll be very interested in seeing an example. Languages where something other than a comma and a space is needed can easily customize it by editing the translation at translatewiki.

The presentation without the comma is implemented using the message wikibaselexeme-description. It's value is $1 $2, and it's marked as "ignored" in translatewiki, which means that it's a message for internal technical use and cannot be translated. This designation is probably incorrect.

My immediate intuition is to do the following:

  • To use wikibaselexeme-presentation-lexeme-secondary-label consistently in every place where showing the lexeme and the part of speech is needed.
  • To examine the usage of wikibaselexeme-description. Perhaps it can be completely removed and replaced with wikibaselexeme-presentation-lexeme-secondary-label. If it's needed, then perhaps it can be changed to $1, $2, but there should be proper justification for having an identical message.

Having identical messages is not necessarily bad, as MediaWiki's Localisation guidelines say. I can think of at least one good justification for having two messages: one can be presented as plain text, which would be good for tooltips, and another one can be parsed with wiki syntax, for showing in context where HTML is available. (The messages don't have markup at the moment, but some languages may want it, for example for fixing RTL issues.) There can be other justifications. But this is really a questions that people who are well-familiar with the code should answer.

I'll be happy to give more L10n advice if needed.


TASK DETAIL
https://phabricator.wikimedia.org/T201808

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Amire80
Cc: Amire80, Jan_Dittrich, WMDE-leszek, Aklapper, VIGNERON, Bugreporter, Lea_Lacroix_WMDE, Lydia_Pintscher, Lexicographical data, KaMan, Nandana, Mringgaard, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, JGirault, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to