[Wikidata-bugs] [Maniphest] [Created] T213793: Fix undefined message params in Wikibase JS, (ViewFactoryFactory & MessageProvider)

[Addshore]

Addshore created this task. Addshore added projects: Wikidata, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION

Follow up to T207421 (specifically T207421#4870565).

In T207421#4870565, @Michael wrote:

The cause is the concatenation in the MessageProvider passed to the ViewFactoryFactory:

{
    getMessage: function ( key, params ) {
        return mw.msg.apply( mw, [ key ].concat( params ) );
    }
},

That concatenation actually adds an element undefined to the resulting array if the params parameter is omitted.

 This was added back in 2015.

 The only place that seems to use it is in ViewFactory. But I may have missed something somewhere.

Possible ways to fix this:


check if param is undefined and then replace it with []
undo the commit that added that code and directly use mw again
remove that MessageProvider and handle it the way we handle messages everywhere else in wikibase (how is that?)

TASK DETAIL

https://phabricator.wikimedia.org/T213793

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Aklapper, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs