[Wikidata-bugs] [Maniphest] [Updated] T213975: Link page from wikimedia.Commons with page exisiting on en.wikipedia with no existing item on wikidata fails

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added subscribers: Michael, Lucas_Werkmeister_WMDE. Lucas_Werkmeister_WMDE added a comment.

The code corresponding to firstSite and _createItem seems to be in client/resources/wikibase.client.PageConnector.js inside the Wikibase git repository, but that file hasn’t been substantially touched in a long time. However, the related lib/resources/wikibase.sites.js file was touched as part of T210744; the change looks innocuous enough to me, but just in case this is another regression similar to T213998 let’s CC @Michael.

diff --git a/lib/resources/wikibase.sites.js b/lib/resources/wikibase.sites.js
index 0c059f421..7dc2d14b9 100644
--- a/lib/resources/wikibase.sites.js
+++ b/lib/resources/wikibase.sites.js
@@ -76,7 +76,7 @@
                 var site = sites[ siteId ],
                     group = site.getGroup();
 
-                if ( $.inArray( group, groups ) === -1 ) {
+                if ( groups.indexOf( group ) === -1 ) {
                     groups.push( group );
                 }
             }

TASK DETAIL

https://phabricator.wikimedia.org/T213975

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Michael, Mbch331, hoo, Lydia_Pintscher, Robby, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, D3r1ck01, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Steinsplitter

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs