| Ladsgroup added a comment. |
I added basic serve-static nodejs libraries that can unblock us from using nginx and it's a good direction to have a nodejs server (then we can inject configs, etc.).
Now I have two issues with prep and deployment:
- prep needs to have env=prod, that makes npm omit installing lots of needed dependencies like grunt, grunt minifiers, etc.
- Speaking of grunt, if I remove env=prod from prep step to make sure it works otherwise, it still fails because Gruntfile.js is not copied over before doing the build step:
---> Using cache ---> b35f86ac2d58 Step 11/34 : ENV APP_BASE_PATH="/srv/service" ---> Using cache ---> 425e1c70eded Step 12/34 : COPY --chown=65533:65533 ["package.json", "./"] ---> Using cache ---> 2cdc1fc68e11 Step 13/34 : RUN npm install ---> Running in c065d9733907
(LOTS OF LOGS) Removing intermediate container c065d9733907 ---> aa4aed71ea93 Step 14/34 : RUN npm "run" "build" ---> Running in 131e5935908e > [email protected] build /srv/service > grunt build A valid Gruntfile could not be found. Please see the getting started guide for more information on how to configure grunt: http://gruntjs.com/getting-started Fatal error: Unable to find Gruntfile. npm ERR! Linux 4.15.0-43-generic npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "run" "build" npm ERR! node v6.12.0 npm ERR! npm v3.10.10 npm ERR! code ELIFECYCLE npm ERR! [email protected] build: `grunt build` npm ERR! Exit status 2 npm ERR! npm ERR! Failed at the [email protected] build script 'grunt build'. npm ERR! Make sure you have the latest version of node.js and npm installed. npm ERR! If you do, this is most likely a problem with the wikidata-query-gui package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR! grunt build npm ERR! You can get information on how to open an issue for this project with: npm ERR! npm bugs wikidata-query-gui npm ERR! Or if that isn't available, you can get their info via: npm ERR! npm owner ls wikidata-query-gui npm ERR! There is likely additional logging output above. npm ERR! Please include the following file with any support request: npm ERR! /srv/service/npm-debug.log The command '/bin/sh -c npm "run" "build"' returned a non-zero code: 1
There are two options now: 1- Move away from Grunt build step (doing it with Make? etc.) it's lots of work 2- Add support for Grunt builds to blubber.
@thcipriani do you think you can do the latter?
TASK DETAIL
EMAIL PREFERENCES
To: Ladsgroup
Cc: Ladsgroup, LarsWirzenius, Lydia_Pintscher, Joe, gerritbot, akosiaris, thcipriani, Addshore, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, mobrovac, Wikidata-bugs, aude, dduvall, Mbch331, Jay8g, greg
Cc: Ladsgroup, LarsWirzenius, Lydia_Pintscher, Joe, gerritbot, akosiaris, thcipriani, Addshore, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, mobrovac, Wikidata-bugs, aude, dduvall, Mbch331, Jay8g, greg
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
