Lucas_Werkmeister_WMDE added a comment. |
Thanks, the flag looks good! Appropriately inconspicuous :)
Text changes would probably be useful, though I’m not sure if they should happen as part of this task. Perhaps a subtask? I also wonder if we should distinguish between mandatory and non-mandatory constraints this way (e. g. change “should” to “must” for mandatory ones)?
Side note: the icons you posted all have a rectangular white background, which looks a bit odd on references. It’s easy to completely remove the background in the SVG source, but I wonder if you think the inside of each icon still should be filled white? Here’s what that would look like:
F28210506: Screenshot_2019-02-13 Douglas Adams.png
I’m still not sure about the size. Are there plans to adjust the text size on Wikidata? (Apparently that’s set by the Vector skin – with Minerva, for example, text and constraint violation icons look larger.) Otherwise, we need to do something with the icons, yes… even at 0.875 scale they still feel a big large:
F28210556: Screenshot_2019-02-13 Douglas Adams(1).png
For comparison, here’s 0.75:
F28210558: Screenshot_2019-02-13 Douglas Adams(2).png
(I took those screenshots by setting transform: scale(FACTOR) on the .wbqc-reports-button via CSS, but especially at 0.875 the scaled icons don’t look good IMHO, so I suspect manual adaptation would be best.) We can also sit together to experiment with this a bit more if you’d like.
Cc: gerritbot, Hanna_Petruschat_WMDE, Jan_Dittrich, Manu1400, abian, Sjoerddebruin, Lucas_Werkmeister_WMDE, Harmonia_Amanda, Aklapper, Lydia_Pintscher, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Agabi10, JGirault, Jonas, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs