hashar added a comment.
In T217285#4990679 <https://phabricator.wikimedia.org/T217285#4990679>, @Addshore wrote: > Federation is not and should not currently be turned on on commonswiki. > It looks like the thing that caused the logspam was indeed media info UI code calling the API, when it should not have been calling it. > However the underlying issue is in Wikibase (and only shows itself on commons now as this is the first time we have not had all entities enabled) > When calls are made to the API for entity types that are not enabled it should fail gracefully, not expose an exception to the user. If I understand it properly, the issue pre date 1.33.0-wmf.19 but surfaced due to media info starting to hit the entry point? Can we possibly get a patch that fails gracefully and avoid the exception / log spam? @matthiasmullie as I got your WikibaseMediaInfo patch <https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseMediaInfo/+/493327/> would stop generating the API requests. I cherry picked it at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseMediaInfo/+/493402/ Assuming WikibaseMediaInfo was the main source of issues, I am willing to promote group1 to 1.33.0-wmf.19 during the European time window (14:00UTC / 45 minutes from now). But I guess we also need a patch to get rid of the exception and convert it to a "nice" api error instead. TASK DETAIL https://phabricator.wikimedia.org/T217285 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Addshore, WMDE-leszek, Ladsgroup, matthiasmullie, TerraCodes, Liuxinyu970226, Stashbot, gerritbot, Aklapper, hashar, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Jonas, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
