daniel added a comment.
In T198341#5021347 <https://phabricator.wikimedia.org/T198341#5021347>, @BPirkle wrote: > rev_text_id references that will be removed/refactored in this task: > > - includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All other references are either gated directly, or are in private functions with all calls gated) see my previous comment > - includes/search/SearchPostgres.php odd stuff, maybe @anomie can help. Two uses seem completely pointless, the third one should probably use getQueryInfo? > - maintenance/Maintenance.php Hm, purgeRedundantText() looks like it needs a switch based on the migration stage. If the SCHEMA_READ_OLD is set, it should read rev_text_id, if SCHEMA_READ_NEW is set, it should read from content.cont_address, and use SqlBlobStore::getTextIdFromAddress to get the numeric ID (if any). > - maintenance/populateContentTables.php See Anomie'S comment > - maintenance/rebuildtextindex.php Just drop the 'text' flag from getQueryInfo() and the rev_text_id = old_id condition. And try that it still works ;) > - maintenance/storage/checkStorage.php Not sure this works at all any more for our wikis, since it has no batching. Anyway, the queries against the text table can stay as they are. The code that builds $this->oldIdMap needs to be modified much like the code in purgeRedundantText() > - maintenance/storage/compressOld.php $fields and friends should come from getQueryInfo(). $textRow and Revision::getRevisionText should be replaced by SqlBlobStore. The logic also needs to be changed so it can process the blobs for multiple slots per revision. Probably needs input from Tim. > - maintenance/storage/fixT22757.php (this script will be removed entirely, pending confirmation from @tstarling ) that > - maintenance/storage/trackBlobs.php Same approach as compressOld.php, same issue with processing multiple blobs per revision. > - tests/phpunit/includes/ActorMigrationTest.php I think Anomie siad somehwre that the rev_text_id stuff should just be removed, right? I recommend doing separate patches for all of these. TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: BPirkle, daniel Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
