EBernhardson added a comment.
From convo about way forward:
14:34 <+ebernhardson> SMalyshev: they basically want to deploy SDC without
breaking commons. If that means they don't have entity search on day 1 that's
ok
14:34 <+SMalyshev> we don't have article+wikibase search
14:34 <+ebernhardson> SMalyshev: today on test-commons searching only
searches entities, and not articles, which is not deployable
14:34 <+SMalyshev> yep so we can exclude entity namespace from defaults
14:35 <+SMalyshev> that would make it the same as before I presume
14:35 <+SMalyshev> wouldn't that be the easiest way?
14:35 <+ebernhardson> i mentioned that taking it out of the default
searchable namespaces would be pretty easy, but ramsay was still worried. He
seemed
to prefer completely disabling entity search over
making it available with that warning message
14:36 <+SMalyshev> well, I am not sure you can completely disable entity
search right now...
14:36 <+SMalyshev> well maybe you can if you set query builder to standard
one.
14:36 <+SMalyshev> that would make it old search
14:36 <+ebernhardson> I could add a config flag that basically says "dont
add special query builder" ?
14:37 <+SMalyshev> ebernhardson: we already have this
14:37 <+ebernhardson> so that might be reasonable, which is it? I'll hack
up beta and see if it works in a way acceptable to them
14:39 <+SMalyshev> so in WikibaseSearchSettings, look for wmgBuilderClass
14:39 <+SMalyshev> right now it chooses between the two entity searchers.
But you can make it choose default one
14:39 <+SMalyshev> non-entity one
14:39 <+ebernhardson> ok, thanks i'll test it out and ping them with results
14:39 <+SMalyshev> for commons. You can add a variable for it or just make
it compare wiki name, however you think is easier
14:40 <+SMalyshev> I *think* that should fix the issue for now (well, but
disabling entity search of course)
14:41 <+SMalyshev> ebernhardson: though may be better would be to make a
different profile
14:41 <+SMalyshev> ebernhardson: yeah I think applying wrong class to a
profile may be wrong... so maybe better to assign different profile instead
14:41 <+SMalyshev> so we have
$wgWBRepoSettings['entitySearch']['fulltextSearchProfile'] =
'wikibase_config_fulltext_query';
14:42 <+SMalyshev> we can make it something else for commons maybe... let
me see how the dispatch actually works...
14:44 <+SMalyshev> ebernhardson: ah dammit no it won't work
14:45 <+SMalyshev> the dispatcher checks if there's a mix of
acticle/non-article NSes, it doesn't care whether the classes are actually the
same
14:45 <+ebernhardson> hmm, can add a check?
14:46 <+SMalyshev> so what we'd need to do is to make
onCirrusSearchFulltextQueryBuilderComplete hook to deactivate.
14:46 <+SMalyshev> probably add a variable for it, since setting UseCirrus
to false would shut off all searches, including wbsearchentity
14:46 <+SMalyshev> if we just want to shut off fulltext, we probably need
another var
14:47 <+ebernhardson> sounds reasonable, i'm going to copy all the above
into ticket
14:47 <+SMalyshev> changing profiles won't help since dispatching builder
does all the checks before anything else
14:47 <+SMalyshev> (maybe when we move DispatchingQueryBuilder inside
Cirrus, it will be easier)
TASK DETAIL
https://phabricator.wikimedia.org/T218954
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: EBernhardson
Cc: Smalyshev, Lea_WMDE, Aklapper, Jdforrester-WMF, dcausse, Cparle,
EBernhardson, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,
EBjune, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
