Pablo-WMDE added a comment.
@Jdrewniak Thanks for getting back to us about this, and for the impressive work you put into moving this to a more 2019-ish implementation. Substantial renovation of legacy code should indeed not be blocked by (questionable) extensions built on top of it - sure way to stall innovation. The tectonic shifts just took us by surprise because we had word to the contrary - but all is well. I have a question regarding the "page-actions menu markup" - this introduces indistinguishable `li`s <https://github.com/wikimedia/mediawiki-skins-MinervaNeue/commit/864a1766a7e547c4a75f64ee4fe730b47fb885d9#diff-5c86360a9410834a55994bea5839a5a8R4> (only the links one step down know the "role") and even hard-wires their order <https://github.com/wikimedia/mediawiki-skins-MinervaNeue/commit/864a1766a7e547c4a75f64ee4fe730b47fb885d9#diff-53f98b517ddd2a1dd51d688cf6fdd2e3R250>. Should the need come up to specify a different order, something that could be conveniently done on the style level <https://stackoverflow.com/a/25077310> nowadays, we'd be lacking the selectors to implement this. Would it not be beneficial to allow action identification already on the list item level? Of course, this is not a completely hypothetical question. For wikibase termbox we are moving the "edit pen" into the individual sections (there is no "page edit") and the hard wiring of order causes us trouble (T215494#5040282 <https://phabricator.wikimedia.org/T215494#5040282> ff.) with the "download action" eventually inconsistently positioned to the right of the "watchlist star" (the only other action). Of course we would also be happy about any other solution suggestion. Thanks for your time! TASK DETAIL https://phabricator.wikimedia.org/T215890 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Jdrewniak, Tarrow, Hanna_Petruschat_WMDE, gerritbot, Jakob_WMDE, Aklapper, Lea_WMDE, Pablo-WMDE, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
