Addshore added a comment.
I am suspect that this was caused by enabling the OLD style of federation on commons in https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/485082/ before then enabling the entity source based federation https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/498165/ Looking through the code path for the new entity source based stuff I can not see why this would be happening (but open to more eyes) The diff cache key is: <!-- diff cache key testcommonswiki:diff:wikidiff2:1.12:old-718:rev-722:1.7.3:25:lang-en --> DifferenceEngine in core caches diffs, which is i thought why the problem remained visible. I went and deleted and then checked the cache key, the key correctly holds the diff now, but the page is still showing the old diff? addshore@deploy1001:~$ mwscript eval.php --wiki testcommonswiki > $c = \MediaWiki\MediaWikiServices::getInstance()->getMainWANObjectCache(); > $r = $c->get( "testcommonswiki:diff:wikidiff2:1.12:old-718:rev-722:1.7.3:25:lang-en" ); > var_dump($r); string(1075) "<tr class="mw-diff-slot-header" lang="en"><th colspan="4">mediainfo</th></tr><tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">Property / <a title="d:Special:EntityPage/P180" href="https://www.wikidata.org/wiki/Special:EntityPage/P180";>depicts</a></td></tr><tr><td colspan="2"> </td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span><a title="d:Special:EntityPage/Q147" href="https://www.wikidata.org/wiki/Special:EntityPage/Q147";>kitten</a></span></ins></div></td></tr><tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">Property / <a title="d:Special:EntityPage/P180" href="https://www.wikidata.org/wiki/Special:EntityPage/P180";>depicts</a>: <a title="d:Special:EntityPage/Q147" href="https://www.wikidata.org/wiki/Special:EntityPage/Q147";>kitten</a> / rank</td></tr><tr><td colspan="2"> </td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span>Normal rank</span></ins></div></td></tr>" Did I miss another layer of caching here? TASK DETAIL https://phabricator.wikimedia.org/T218921 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, WMDE-leszek, Aklapper, Jdforrester-WMF, alaa_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, rosalieper, Jonas, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Lydia_Pintscher, Fabrice_Florin, Matanya, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
