Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Shape Expressions. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION As an editor, I want to be sure that when I “edit” a Schema, but don’t make any actual changes, then no edit to the page is made. **Problem:** Currently, it’s possible that an edit is made even if there is no difference, because the underlying JSON serialization may change. **Example:** This diff <https://wikidata-shex.wmflabs.org/wiki/Special:Diff/103/104> is empty, but in the underlying JSON representation, the `aliases` changed from having `"de": [], "fr": [], "nl": []` in revision 103 <https://wikidata-shex.wmflabs.org/w/index.php?oldid=103&action=raw> not not having those empty lists anymore in revision 104 <https://wikidata-shex.wmflabs.org/w/index.php?oldid=104&action=raw>. **BDD** WHEN I go to edit a schema AND I only add whitespace at the beginning or end of labels, descriptions, aliases, or schema text THEN no edit is recorded in the page history when I save **Open questions:** - There are two ways we can tackle this (not necessarily exclusive). Which one(s) do we want to pursue? - Try to always generate the same JSON (strip empty `aliases` arrays, consistent key order, etc.). However, this will still produce empty edits if the serialization version changes. - Diff the old and new Schema and don’t save if the difference is empty. TASK DETAIL https://phabricator.wikimedia.org/T219173 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, pdehaye, alaa_wmde, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
