alaa_wmde added a comment.
I had only time to look into one failing test (fails locally too on master) In `GrammaticalFeatureListWidget.test.js` two tests fail: `I can preset selected values` and `I can preset selected values with labels`. According to https://github.com/wikimedia/oojs-ui/blob/master/src/widgets/MenuTagMultiselectWidget.js#L233 our tests either miss configuration `allowArbitrary: true` or we are missing to initialize the select widget menu properly. Though our code `GrammaticalFeatureListWidget.js` does not initialize with `allowArbitrary` and that config was *not* introduce recently. Sorry I didn't have more time to continue on it TASK DETAIL https://phabricator.wikimedia.org/T219134 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Lucas_Werkmeister_WMDE, alaa_wmde, Aklapper, Jakob_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
