Krinkle reopened this task as "Open". Krinkle added a comment.
In T97891#1274336 <https://phabricator.wikimedia.org/T97891#1274336>, @gerritbot wrote: > Change 209870 had a related patch set uploaded (by Florianschmidtwelzow): > Don't output an empty h1 element > > https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/209870/ This was effectively reverted in d56792addb <https://phabricator.wikimedia.org/rSVECd56792addb8464997772b566db71a78c39e5cf30> (change 500805 <https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/500805/>) to fix T219864 <https://phabricator.wikimedia.org/T219864>. I think the original use case of allowing extensions to control part of the skin layout is interesting and worth exploring still. Having said that, it seems Flow, Echo and Wikibase no longer use this feature (and Gather was undeployed). I wasn't able to find a use of it in Codesearch, but maybe I missed it? I'd be interested in re-considering this feature with a specific use case in mind to see how we can best balance the need for flexibility, and the maintenance cost + developer usability involved. There are also other ways to do this, such as through a Skin method, or through a documented CSS class. It might then also make sense to tailer the interface to a more specific semantic intent so that the skin can respond in some way rather than just leaving a gap in its design. The notion of "Don't render the h 1" seems rather specific and hard to accommodate universally in all designs. Not to mention the impact on other extensions and gadgets from a central element missing on the page. TASK DETAIL https://phabricator.wikimedia.org/T97891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian, Krinkle Cc: Krinkle, gerritbot, KLans_WMF, adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Isarra, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
