daniel added a comment.
In T198342#5083815 <https://phabricator.wikimedia.org/T198342#5083815>, @BPirkle wrote: > Usages found: > > - includes/api/ApiQueryAllRevisions.php, line 85, in function run() > - includes/api/ApiQueryRevisions.php, line 162, in function run() (if $this->fetchContent is true) As far as I can see, these can just be deleted. Your work on ApiQueryRevisionsBase has made them redundant. > - maintenance/testCompression.php line 51 Can be deleted. The idea of setting the 'text' flag here is basically a pre-fetch: the old code in Revision would make use of old_text and friends directly if present in the row from a join, and would make a separate database query if not. The new code will always do a separate query if SCHEMA_COMPAT_READ_NEW is set, since there may be more than once slot to read. Any old_xxx fields passed to the constructor are ignored. Thus, the 'text' flag can just be deleted. Note that the extra query isn't so terrible because we'd be doing a separate query to ExternalStore anyway. A bulk mode in BlobStore would still be nice to have. By the way: while you are looking at testCompression.php, it would be nice to replace the usage of the deprecated Revision class with RevisionStore/RevisionRecord. This brings us back to having a way to access slot content without constructing a RevisionRecord. This wouldn't need much more than making RevisionStore::loadSlotRecords public. If you feel like it, go ahead :) Should probably have a separate ticket though... > - tests/phpunit/includes/RevisionDbTestBase.php, line 1601, in function testGetRevisionText(), via data provider provideGetRevisionText() > - tests/phpunit/includes/RevisionMcrReadNewDbTest.php, data provider provideGetRevisionText() Of theRevisionDbTestBase subclasses, RevisionMcrReadNewDbTest and RevisionMcrWriteBothDbTest and RevisionPreMcrDbTest should test the 'text' flag, the others should not. In the base class, the provider should probably be abstract. > - test/phpunit/includes/Revision/RevisionQueryInfoTest.php line 1054, in function testRevisionGetQueryInfo(), via data provider provideQueryInfo() > - test/phpunit/includes/Revision/RevisionQueryInfoTest.php line 1068, in function testRevisionStoreGetQueryInfo(), via data provider provideQueryInfo() Keep, since the relevant test case forces wgMultiContentRevisionSchemaMigrationStage to SCHEMA_COMPAT_OLD. TASK DETAIL https://phabricator.wikimedia.org/T198342 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: BPirkle, Aklapper, aude, Addshore, Anomie, Jdforrester-WMF, Tgr, gerritbot, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
