Addshore added a comment.

  I have no idea how these queries would perform, but they are scary and I 
don't think we should be running them on the production master DB.
  If cleanup is wanted from some sort of maintenance script it should probably 
use batches of deletes and or selects.
  
  For point 4 in the task description, I don't see where the extra work really 
comes from? The logic for cleaning up the tables is the same and needs to be 
written no matter what, it will just be wrapped in some deferring code.
  
  We decided at some point that we can't do 1, so the Dev work need to happen.
  
  The maintenance script just sounds like another thing that we need to keep 
running, make sure it's deleting, and will be slow.
  
  Deleting them as part of the save could be fine, but it will make saving 
slower, deferring this cleanup is just to keep saves as lean as possible.

TASK DETAIL
  https://phabricator.wikimedia.org/T220150

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Ladsgroup, Addshore, alaa_wmde, Aklapper, JeroenDeDauw, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to