Jdforrester-WMF added a comment.
In T209879#5107093 <https://phabricator.wikimedia.org/T209879#5107093>, @Lucas_Werkmeister_WMDE wrote: > I’m not sure how the graduation requirements apply to this task – some clarification from the beta masters would be appreciated :) Sure. :-) > What exactly needs to go through another design, security and performance review, given that the feature is essentially just one JavaScript file (plus a bit of PHP bootstrapping) in a much larger PHP extension that’s already deployed everywhere? The design review is at the discretion of the product owner of the relevant area (it's to make sure we're not pushing things into production by default that radically break the design concept of everything around them). The security concern shouldn't be needed; if there were security concerns, the code should have been removed from production already. The performance concern relate to tools which scale with 10 users but will break production if you have 100,000; if you as a team are comfortable with the load/profile. > How will the deployment work? T220609 <https://phabricator.wikimedia.org/T220609> has three Gerrit changes at the moment: effectively enable the feature for everyone; remove the beta feature from the extension; remove the beta feature from mediawiki-config. Which ones of these go with the train and which go through SWAT, and in what order are they deployed? Do we need more changes to first add a feature flag whether the feature is enabled for everyone, and then SWAT that, before the beta feature is removed? Generally, just have the enable-for-all change (and remove the beta feature code) in the code repo that rides the train, then the next week when you're sure the train won't regress, drop the beta feature config from MW config. TASK DETAIL https://phabricator.wikimedia.org/T209879 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdforrester-WMF Cc: greg, Jdforrester-WMF, WMDE-leszek, Lucas_Werkmeister_WMDE, Lea_Lacroix_WMDE, Aklapper, Lydia_Pintscher, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Jonas, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
