aaron added a comment.

  In T212550#5124280 <https://phabricator.wikimedia.org/T212550#5124280>, 
@Krinkle wrote:
  
  > Another question for @aaron as well - If we start storing this 
chronologyprotector field in kafka etc. that means it can survive longer and no 
longer has an expiry like we do for cookies. I vaguely recall an issue in the 
past where clients that kept the value too long caused subsequent requests to 
stall for many seconds as MW mistook the unknown value for a value that hasn't 
appeared yet.
  >
  > It may've been mitigated already, but if not, we'll need to sort that out 
before this goes live.
  
  
  That was cpPosIndex for cookies, which was changed to include 
timestamp/clientId so that old values are ignored server-side. Use of client 
IDs alone will never cause wait delay on the position store itself, which is 
fine for this sort of EventBus use case; the DB changes and kafka enqueue 
happen in the master DC and the jobs run in the master DC as well, so there is 
no need to wait on cross-DC position store replication. By not doing so, it 
also avoids any risk of weird cases causing wait timeout delay.

TASK DETAIL
  https://phabricator.wikimedia.org/T212550

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron
Cc: Krinkle, Ottomata, Aklapper, Smalyshev, aaron, alaa_wmde, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, 
Vali.matei, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Xmlizer, 
jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to