Reedy closed this task as "Resolved".
Reedy added a comment.
As far as I'm concerned, this is good to go. A little bit of cleaning up, but
nothing security specifically
"version": "0.0.0",
Might want to set that to something > `0.0.0` before deploying it :)
`switch(true)` feels odd.
`SchemaEditAction::getName()` the `* @since 1.17` seems out of place, it's
since 1.17 in MW, not in this extension (and other `FormAction` subclasses,
they override `getName()` but don't have this copied forward comment)
Some minor php documentation issues, you use `return bool` and `return false`
in difference places, even if only in the first case, the code only returns a
false.
SchemaConverter has quite a lot of very similar looking duplicate code in the
get functions. But as differences of values/properties in handling may come
later, it's probably not worth much "condensing". Maybe some of the error early
returns could be condensed.
Some very minor bits of cleanup/standardisation/simplification in
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseSchema/+/505662/
TASK DETAIL
https://phabricator.wikimedia.org/T216692
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Reedy
Cc: Tarrow, Aklapper, RazShuty, WMDE-leszek, Michael, noarave, Lydia_Pintscher,
Lucas_Werkmeister_WMDE, pdehaye, alaa_wmde, mmarble, Nandana, sbassett, Lahi,
Gq86, GoranSMilovanovic, QZanden, EBjune, YULdigitalpreservation, LawExplorer,
Salgo60, _jensen, rosalieper, dpatrick, Luke081515, freephile, abian,
Wikidata-bugs, aude, JanZerebecki, csteipp, Mbch331, Jay8g, Legoktm
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
