Lucas_Werkmeister_WMDE added a comment.
In T212869#5135925 <https://phabricator.wikimedia.org/T212869#5135925>, @hoo wrote: > In T212869#5122970 <https://phabricator.wikimedia.org/T212869#5122970>, @Lucas_Werkmeister_WMDE wrote: > > > Unfortunately the `ChangeOp` approach seems to have the same problem: it uses the base revision, not the parent revision, to check if the label and the description are the same :( > > > But you still went with it (indirectly, as the FingerprintValidator you're adding is used there)? Does that cause problems elsewhere? Is there a task for that? We might have tested something wrong – with the changes linked above, I can’t reproduce this problem anymore. TASK DETAIL https://phabricator.wikimedia.org/T212869 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Greta_Doci_WMDE, Lucas_Werkmeister_WMDE Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
