Lucas_Werkmeister_WMDE added a comment.
In T212869#5135995 <https://phabricator.wikimedia.org/T212869#5135995>, @alaa_wmde wrote: > The problem comes from the fact that UI is making two separate requests for what appears to be an atomic action (save all changed terms) to the editor. While that haven't caused any issues before now, and probably was decided to be done that way so that changing labels, descriptions and aliases get their own edit revisions separate from each other (for easier rollbacks and more atomic history on level of term edits), bubbling up this kind of separation up to the UI is problematic in this case. I’m pretty sure it //has// caused issues before now, we just haven’t addressed them yet. Part of the reason why it’s not great to use `wbeditentity` for these edits is that it results in a very generic edit summary (compare T67846 <https://phabricator.wikimedia.org/T67846> or T191885 <https://phabricator.wikimedia.org/T191885>), but that will be tackled soon as part of the termbox hike, which already uses `wbeditentity`: T220696: Create better Termbox edit summaries for wbeditentity endpoint <https://phabricator.wikimedia.org/T220696> However, I don’t think that needs to block this task. For now, it’s okay if the label edit goes through and the description is blocked (my understanding is that these cases are often mistakes by confused users, where the label is correct but the description isn’t), and we can switch to `wbeditentity` later, once it has better edit summaries. TASK DETAIL https://phabricator.wikimedia.org/T212869 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Greta_Doci_WMDE, Lucas_Werkmeister_WMDE Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
