Smalyshev added a comment.
BTW I am not sure how MediaInfoIdLookup is supposed to work:
if ( !$title->inNamespace( $this->mediaInfoNamespace ) ) {
return null;
}
try {
return new MediaInfoId( $title->getText() );
} catch ( InvalidArgumentException $ex ) {
return null;
}
The file pages are in NS_FILE namespace and generating MediaInfoId from their
title is sure to fail. And there's no separate namespace for MediaInfo entities
anymore, as I understand. So what this code actually is supposed to do?
@daniel, @WMDE-leszek - is this relevant anymore?
TASK DETAIL
https://phabricator.wikimedia.org/T222299
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Smalyshev
Cc: Mholloway, WMDE-leszek, Jdforrester-WMF, matthiasmullie, Cparle, daniel,
Lucas_Werkmeister_WMDE, Tpt, Addshore, Ramsey-WMF, Aklapper, Smalyshev,
alaa_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Anooprao,
SandraF_WMF, GoranSMilovanovic, QZanden, EBjune, Tramullas, Acer, merbst,
LawExplorer, Salgo60, Silverfish, Poyekhali, _jensen, rosalieper, Jonas,
Xmlizer, Susannaanas, Wong128hk, Jane023, jkroll, Wikidata-bugs, Jdouglas,
Base, aude, Tobias1984, El_Grafo, Dinoguy1000, Manybubbles, Ricordisamoa,
Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331,
Keegan
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
