thiemowmde triaged this task as "Low" priority. thiemowmde moved this task from incoming to needs discussion or investigation on the Wikidata board. thiemowmde added a project: good first bug. thiemowmde added a comment.
Here is the line of code that is responsible for the current behavior: https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/repo/includes/ChangeOp/Deserialization/AliasesChangeOpDeserializer.php$125. counterexample if ( $aliasesToSet !== [] ) { This file exists since https://gerrit.wikimedia.org/r/334142 (not linked to a Phabricator ticket), mostly copied from the EditEntity class. In EditEntity the line was originally introduced in 2013 via https://gerrit.wikimedia.org/r/73322, bug T52983 <https://phabricator.wikimedia.org/T52983>. The bug was about the UI accidentally removing all aliases when it shouldn't. This means: - No, the fact an empty list of aliases is ignored is not an intentional product feature. It was a bugfix for a misbehavior. - As long as we can make sure the bug does not come back, I believe we can remove the special case and allow users to pass an empty list of aliases to the API. Proposed fix: if ( $aliasesChangeOps->getChangeOps() === [] || $aliasesToSet !== [] ) { TASK DETAIL https://phabricator.wikimedia.org/T203337 WORKBOARD https://phabricator.wikimedia.org/project/board/71/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Pablo-WMDE, Matthias_Geisler_WMDE, RazShuty, Lea_WMDE, Jakob_WMDE, Liuxinyu970226, Tarrow, Aklapper, Danmichaelo, darthmon_wmde, MattLongCT, alaa_wmde, DannyS712, Nandana, Kieubinhtb, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, JakeTheDeveloper, QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
