Anomie added a comment.
In T125050#5120646 <https://phabricator.wikimedia.org/T125050#5120646>, @hashar wrote: > Scribunto has a set of test to make sure it works fine with some LUA interpreters. That is really nice but takes a few minutes iirc. When one send a patch for another extension, we are 100% sure they are not going to affect how LUA runs. - There are 6 tests that test PHP hooks (in tests/phpunit/common), with no Lua involved. Probably more should be written. - These take 1–2 seconds on my laptop. - There are 67 for LuaStandalone integration (in tests/phpunit/engines/LuaStandalone). - These take 6–7 seconds on my laptop. - There are 46 for LuaSandbox integration (in tests/phpunit/engines/LuaSandbox). - These take about 5 seconds on my laptop. - Then there are the 1000+ tests in tests/phpunit/engines/LuaCommon, which are run for both LuaSandbox and LuaStandalone to ensure things work under both environments. - The run for LuaSandbox takes around 34 seconds on my laptop, and the run for LuaStandalone takes around 163 seconds. The last category is testing the code in case of subtle differences between the two environments, rather than Scribunto itself's integration with the environments, so calling them "system-integration" wouldn't really be accurate. You could probably use the existing 'LuaStandalone' group like you proposed the 'system-integration' group. I don't think 'system-integration' would be an accurate group name, but if we can think of one that would be accurate for "tests not worth running when testing other extensions" I wouldn't be opposed to having Scribunto's suite tag the LuaStandalone tests with that too. TASK DETAIL https://phabricator.wikimedia.org/T125050 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Pablo-WMDE, Jakob_WMDE, Tarrow, gerritbot, Addshore, TerraCodes, Liuxinyu970226, EBernhardson, Smalyshev, greg, Legoktm, Stashbot, Lydia_Pintscher, Aleksey_WMDE, Ladsgroup, WMDE-leszek, Anomie, hashar, aude, thcipriani, Paladox, hoo, Aklapper, JanZerebecki, StudiesWorld, darthmon_wmde, Redabr4, alaa_wmde, Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Xinbenlv, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, SundanceRaphael, _jensen, rosalieper, Jonas, Wikidata-bugs, Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
