hashar added a subscriber: Smalyshev.
hashar added a comment.

  Here is an explanation of the issue @Smalyshev encountered on T219749 
<https://phabricator.wikimedia.org/T219749> as I posted it on 
https://gerrit.wikimedia.org/r/#/c/integration/config/+/511308/
  
  The failure comes from the CI tests for wikidata/query/rdf which are run by 
the Maven test suite.  The job doing that is 
wikidata-query-rdf-maven-java8-docker which really just ship java8 and then 
runs maven.  There is no chromedriver being spawned.
  
  The wikidata/query/rdf test suite then run the GUI test suite using npm, but 
since the gui code uses wdio/chromedriver and the maven image does not have it 
... The suite fails to connect to chromedriver ( ECONNREFUSED 127.0.0.1:4444 ).
  
  I am not sure whether the GUI test should be run as part of testing 
wikidata/query/rdf .  Probably only a subset of them should?
  
  -----------
  
  For `wikidata/query/gui`, the CI job runs `npm test` which in turns seems to 
invoke `grunt test`. So I guess it is all about adding `wdio` task to the list 
of tasks executed when running `grunt test`. Specially, revert 
https://gerrit.wikimedia.org/r/#/c/wikidata/query/gui/+/506666/
  
  BUT, in `wikidata/query/rdf`, as soon as the GUI submodule is updated, the 
test will fail since they are run with maven and the container does not have 
chromedriver nor is it intended to run wdio test.   My big question is: do you 
actually need to run the GUI npm test when testing `wikidata/query/rdf` ?  That 
seems to just rerun tests that already ran perfectly fine in the upstream repo 
`wikidata/query/gui`.

TASK DETAIL
  https://phabricator.wikimedia.org/T222200

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: Smalyshev, hashar, zeljkofilipin, noarave, alaa_wmde, WMDE-leszek, 
Aklapper, E.S.A-Sheild, darthmon_wmde, Ferenczy, sarhan.alaa, Samuditha24, 
IM3847, joker88john, CucyNoiD, Nandana, NebulousIris, kostajh, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Chicocvenancio, Th3d3v1ls, Ramalepe, MichaelSchoenitzer_WMDE, 
Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, Jogi_don, 
_jensen, rosalieper, D3r1ck01, Jonas, thcipriani, Wikidata-bugs, Jdlrobson, 
aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to