WMDE-leszek added a comment.
Sorry for not putting this in here earlier. My and @Lydia_Pintscher had a brief chat about the desired behaviour of the termbox (or broader, Wikibase in general), and concluded following: 1. If the ULS or any source of language code list provides a language code (and possible related data in this language) that is not recognized by Wikibase, this entry must not be presented to the user. 2. When data load from the storage contains entries using a language code that is not recognized by Wikibase, those entries must not be presented to the user (e.g. for reason X there a label related to the invalid language code stored in the DB, JSON data returned by the API should never expose this invalid label 3. When data containing data with the language code that is not recognized by Wikibase is requested to be stored (e.g. edit made via UI, or bot API, etc), the API getting the request should refuse to save the data and show the error informing on the invalid language code in the request. @Lydia_Pintscher could you please confirm that I got all above right and I am not making up the truth? @Lea_WMDE in the termbox case points 1 and 3 are particularly relevant. It seems that for this very task, there is an acceptance criterion missing (although it actually is the current title of this task), that if the ULS provides language code which is not recognized by Wikibase, it should be ignored, and there should not be a row in the termbox related to this language code. This would fulfill the behaviour requirement 1. Re requirement 3, the termbox v2 is compliant as long as the API providing item data is compliant with the requirement 2. This is considered to be the case now as T200432 <https://phabricator.wikimedia.org/T200432> has been resolved. Some changes to Wikibase API presenting data would be still recommended but these are out of scope of the termbox work, and also not considered critically urgent with the current state of the language data in Wikidata storage layer. Hence, there is no changes needed to termbox v2 with regards to editing/persistence. TASK DETAIL https://phabricator.wikimedia.org/T217770 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: Tarrow, Addshore, Lydia_Pintscher, Pablo-WMDE, gerritbot, WMDE-leszek, Lea_WMDE, Hanna_Petruschat_WMDE, Aklapper, E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
