alaa_wmde created this task. alaa_wmde added projects: Wikidata wb_terms Trailblazing, Wikidata.
TASK DESCRIPTION The initialization logic for DatabaseTermIdsAcquirer that will be passed to DatabaseItemTermStore and DatabasePropertyTermStore will be concerned about providing the callback function. These two classes receive the acquirer as a constructor rparameter. To hide the callback logic from the singleton/factory that creates the acquirer and pass it through to these two classes, we can do one of two things (from cleanest to dirtiest, the opposite order would put the least effort/most pragmatic ones first): - allow `DatabaseTermIdsAcquirer` to accept multiple callbacks, adding a method to add new ones to in stance, say `addTermIdsConsumerCallback` => these two classes can add their callbacks to the instance that is passed to them - just provide a setter method for the callback on `DatabaseTermIdsAcquirer` => these two classes can use to set their callbacks on the passed acquirer instance - initialize Acquirer inside these two classes instead of it being passed to the constructor as done now => provide the callback as part of initialization TASK DETAIL https://phabricator.wikimedia.org/T225050 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Aklapper, alaa_wmde, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
