akosiaris added a comment.
@tarrow, @WMDE-leszek Hi, sorry for taking so long to answer to this, it's been really busy. In T220402#5214471 <https://phabricator.wikimedia.org/T220402#5214471>, @Tarrow wrote: > @mobrovac Thanks! I think we've now taken most of this onboard and merged it. > > @akosiaris could you take a look at out new x-amples block and Host header? Hopefully this meets our needs :). I did have a look. Thanks for catering to the Host header support! I 've updated the helm chart to honor the above and went through a testing phase. I've also added you both as maintainers of the helm chart. https://gerrit.wikimedia.org/r/515028 Almost everything is fine, except some issue in the generator for the x-amples in the HEALTHCHECK_URL. The generated /openapi.json stanza in question is "x-amples": [ { "title": "get rendered termbox", "request": { "query": { "language": "de", "entity": "Q1", "revision": 103, "editLink": "/edit/Q1347", "preferredLanguages": [ "de", "en" ] }, "response": { "status": 200, "headers": { "content-type": "text/html" } } Note how preferred languages is an array indeed but is not pipeDelimited as the openapi spec requires, but is rather given in an array format and not as a pipedelimited string. That in turn causes service-checker to error out with the following DEBUG:urllib3.connectionpool:http://192.168.99.100:18788 "GET /termbox?revision=103&editLink=%2Fedit%2FQ1347&entity=Q1&preferredLanguages=%5B%27de%27%2C+%27en%27%5D&language=de HTTP/1.1" 400 169 /termbox (get rendered termbox) is CRITICAL: Test get rendered termbox returned the unexpected status 400 (expecting: 200) as it tries to convert `[`] and `]` into url encoded strings, thus creating a parameter than violates the spec and making the health check fail. I had a quick look at the code but found no quick way to fix it, could you please have a look? TASK DETAIL https://phabricator.wikimedia.org/T220402 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: akosiaris Cc: Krenair, fsero, mobrovac, Matthias_Geisler_WMDE, Pablo-WMDE, Dzahn, Addshore, Tarrow, Lea_WMDE, WMDE-leszek, Jakob_WMDE, Aklapper, akosiaris, E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, Legado_Shulgin, CucyNoiD, Nandana, NebulousIris, thifranc, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, Liudvikas, Wong128hk, Eevans, thcipriani, Hardikj, Wikidata-bugs, aude, Lydia_Pintscher, dduvall, faidon, Jdforrester-WMF, Mbch331, Jay8g, fgiunchedi
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
