Smalyshev added a comment.
> Can we get away with a 'dumpwikibaserdf.sh' and some well-chosen variables for both wikidata and commons (or at worst two much much shorter scripts) instead of a whole new dumpcommonsrdf.sh? I thought about it, and it might be possible, but it would make the script even more complex and even less readable, as it would be pretty much everything variables on top of variables on top of variables. That's why I didn't go that route - too easy to make an error while piling those variables on top of each other, and would be too hard to find one... I understand copypasting is usually bad, but I wonder if we want to tolerate it for the sake of readability. If you think it's a must I can redo it using common script but that would probably make the common part harder to understand and verify. > Mediainfo is the first name I would have chosen too but maybe we can find something else that will keep future dump maintainers from swearing at us. That's a good time for proposals, while we have not committed to anything yet. That said, given that it'd be in other/wikibase/commonswiki, I don't think it can be confused with anything else. > Last comment is that I really dislike the links under xmldatadumps/public/{wikidata,commonswiki}. That directory should be only for xml/sql dumps and we should be moving away from having links to other stuff there, not adding new ones. We need a plan... I just did what wikidata dump is already doing. I do not have any opinion on which way is better, but I think it should be symmetric for both RDF dumps - either both have it, or none has it. So you are welcome to propose any model that you prefer, I do not have preferences here except for consistency. TASK DETAIL https://phabricator.wikimedia.org/T221917 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: ArielGlenn, WMDE-leszek, Poyekhali, Steinsplitter, Aklapper, Lydia_Pintscher, Bugreporter, Tgr, Ramsey-WMF, Jarekt, Addshore, Tpt, MB-one, Salgo60, Lucas_Werkmeister_WMDE, Smalyshev, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, Tramullas, Acer, merbst, LawExplorer, WSH1906, Lewizho99, Maathavan, Silverfish, _jensen, rosalieper, Jonas, Xmlizer, Susannaanas, Wong128hk, Jane023, jkroll, Wikidata-bugs, Jdouglas, Base, matthiasmullie, aude, Tobias1984, El_Grafo, Dinoguy1000, Manybubbles, Ricordisamoa, Wesalius, Fabrice_Florin, Raymond, Jdforrester-WMF, Mbch331, Keegan
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs