alaa_wmde added a comment.
In T225003#5249128 <https://phabricator.wikimedia.org/T225003#5249128>, @Lucas_Werkmeister_WMDE wrote: > That makes sense to me – it also matches `TermBuffer`’s `array $termTypes = null, array $languageCodes = null` arguments. A separate method doesn’t seem necessary, and a cloning setter seems harder to use to me. And a `TermIdsResolverFilter` interface doesn’t really work, I think, because you can’t actually inject arbitrary instances of the interface there, the implementation will have to know how to filter for it in the database. (Also, that would open the door to a `MatchingPrefixTermIdsResolverFilter`, i. e. a kind of search, which we don’t actually want to support as far as I understand.) Make sense to me too! TASK DETAIL https://phabricator.wikimedia.org/T225003 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, alaa_wmde Cc: alaa_wmde, Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
