pmiazga created this task. pmiazga added projects: MobileFrontend, MediaWiki-extensions-WikibaseClient, Readers-Web-Backlog, Technical-Debt. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata.
TASK DESCRIPTION MobileFrontend can show nice article taglines (can be enabled by MFDisplayWikibaseDescriptions) . Sadly, this feature causes a hard dependency on WikiBase, and maitenance cost, as MobileFrontend has to know how to build Wikibase entities. It's not MobileFrontend reponsibility, thus should be removed from MobileFrontend codebase. Acceptance Criteria ------------------- [ ] Article tagline is set up by the hook. MobileFrontendHooks::findTagLine <https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/b29ec88fac3a92dc85e500e6a1dd6c30fcc01975/includes/MobileFrontendHooks.php#L1030> should run a new hook. [ ] Wikibase Client runs the hook to fill the Article tagline [ ] `ExtMobileFrontend::getWikibaseEntity()` and `ExtMobileFrontend::getWikibaseDescription()` should be removed Open questions -------------- - Should we rename the `MFDisplayWikibaseDescriptions` config? - Should we rename MobileContext:shouldShowWikibaseDescriptions() method? Developer notes: ---------------- Proposed Hook name: `MobileFrontendFetchArticleTagline` TASK DETAIL https://phabricator.wikimedia.org/T225529 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: pmiazga Cc: pmiazga, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, mojoaxel, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Winter, _jensen, rosalieper, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
