Krinkle added a comment.
In T225212#5241912 <https://phabricator.wikimedia.org/T225212#5241912>, @hoo wrote: > > Notice: Undefined variable: wmgWBRepoConceptBaseUri in /srv/mediawiki/wmf-config/Wikibase.php on line 149 > > This is because the default was set to `null` and that makes `SiteConfiguration::getAll` [..] omit the variable completely. This seems like something we should fix. Variable existence is not something we normally use intentionally to inform behaviour, so I think SiteConfiguration should always export the variable. On top of that, the patch even explicitly specified `'default' => null` which means even if we were to support variables that only conditionally exist, this would be a condition in which it should exist. TASK DETAIL https://phabricator.wikimedia.org/T225212 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, Lucas_Werkmeister_WMDE, hoo, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
