Igorkim78 added a comment.
The idea for the change is to replace runLast hint with more complicated logic. So there are 3 steps: - first 'most probable optimal' placement to allow for EmptyLabelServiceOptimizer to see the variables to process. - then EmptyLabelServiceOptimizer adds statement patterns for resolutions. - and then additional optimizer step rearranges LabelService to the latest possible step before any clauses, which might use the variables bound by LabelService. All tests in LabelServiceUnitTest (including new specific testcase from this bug) are passing, but I think it might take some additional tuning to properly support all 'real-life' usage scenarios. For example FILTER clauses, including those which are written above service calls and binds. These might also need additional rearrangement. I have not applied them yet, as this might become a waterfall, which will rearrange the clauses to much. TASK DETAIL https://phabricator.wikimedia.org/T175840 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Igorkim78 Cc: Smalyshev, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, ET4Eva, Nandana, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Gehel, _jensen, rosalieper, Cirdan, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
