Addshore added a comment.
So, there is no problem with having waitForReplication in jobs, but it should probably only be done in the case of batching, which is unlikely or us in production, but theoretically possible. So IMO the job should run the first batch, and then if it needs to run another batch, it should waitForReplication first. Right now the batch size isn't configurable, but in an ideal it would be for 3rd party users to be able to tweak for their situations (and that's when the batching and waitForReplication would most likely actually come into play). Then for the maint script, after each job is ->run() is should probably have a waitForReplication. TASK DETAIL https://phabricator.wikimedia.org/T226635 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, Marostegui, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
