alaa_wmde added a comment.
@maho re feedback on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/512393 > Do we even want to do this via Prometheus (WikimediaPrometheusSparqlEndpointReplicationStatus) Sounds like the right thing to do so to me too, as per https://phabricator.wikimedia.org/T221774#5165165. Warning though, I have very limited knowledge so far on what Prometheus is setup to monitor in our stack. Links are welcome :) If I understand correctly, it's main and probably only downside is when Prometheus has outdated data on the lag for some reason (if WDQS instance is down/depooled? or the refresh job fails often?) .. which is the same scenario that raises your last questions, I believe: > Shall we disregard lag data if it's really old I think here I'd rather keep counting that lag. It is at the end the latest known lag to the user querying the lag (last refresh, refresh rate and interval are implementation details). And to this implementation detail, if the latest lag that is known is much farther in the past than I expected it to be, then I should for safety sake go with the assumption that the instance is actually lagging at least that much rather than assuming than risking ignoring that lag, which might in edge cases result in processing the edit instead of rejecting it due to lag. Does that sound reasonable? or did I misunderstood too much in there? > If yes, where should WikimediaPrometheusSparqlEndpointReplicationStatus live? Here or in the Wikidata.org extension? That thing is definitely better to live outside of Wikibase codebase, if possible, in an extension/external library that is more Wikidata. is there such place? what is "Wikidata.org extension"? and did you want to name it `WikidataPrometheusSparqlEndpointReplicationStatus` (Wikidata instead of Wikimedia), or why Wikimedia? I'm also wondering if the whole thing (interface and other implmenetation `SparqlEndpointReplicationStatusStateHandler` etc) can as well live outside Wikibase Repo? (I'm assuming Wikibase Repo has no code related to WDQS but I can certainly be off here, haven't checked yet). > Do we (also?) want to have a pure SPARQL implementation? In case we do Prometheus based solution, then I wouldn't keep two implementations unless I want to use one as a fallback for the other one. Are you thinking of using SPARQL implementation as a fallback in case Prometheus is not reachable? TASK DETAIL https://phabricator.wikimedia.org/T221774 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, alaa_wmde Cc: alaa_wmde, Andrawaag, Multichill, Ladsgroup, Smalyshev, fgiunchedi, hoo, Daniel_Mietchen, MisterSynergy, Addshore, Sjoerddebruin, Aklapper, Lucas_Werkmeister_WMDE, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Chicocvenancio, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, WSH1906, Lewizho99, Volans, Maathavan, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
