Ladsgroup added a comment.
In T227031#5300417 <https://phabricator.wikimedia.org/T227031#5300417>, @Lucas_Werkmeister_WMDE wrote: > In T227031#5299637 <https://phabricator.wikimedia.org/T227031#5299637>, @jjkoehorst wrote: > > > The issue identified was because the custom-config.json was not overwriting the settings stored in default-config.json. To overcome this a pull request was made that overwrites the default-config.json file upon startup. > > > > See: https://github.com/wmde/wikibase-docker/pull/85 > > > If custom-config.json doesn’t override default-config.json, doesn’t that mean the query UI has to be fixed, rather than overriding default-config.json in Docker? The whole point of the separation was that default-config.json doesn’t have to be changed, after all. No, Let me explain in depth: WDQS GUI checks for existence of custom-config.json on its root directory (see wikibase/config.js <https://github.com/wikimedia/wikidata-query-gui/blob/master/wikibase/config.js#L77>) and overrides values of default-config.json if it finds them. The issue with the docker image was that it was put in the wrong directory (See PR <https://github.com/wmde/wikibase-docker/pull/85/files> and working directory <https://github.com/wmde/wikibase-docker/blob/master/wdqs-frontend/latest/Dockerfile#L36>) causing the config.json not to pick up the file. Now that's fixed. (I double checked everything) TASK DETAIL https://phabricator.wikimedia.org/T227031 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Lucas_Werkmeister_WMDE, hoo, Realworldobject, Lea_Lacroix_WMDE, jjkoehorst, Andrawaag, Addshore, Aklapper, darthmon_wmde, alaa_wmde, Jelabra, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
