Jakob_WMDE added a comment.
The only type of metrics emitted via the service runner template are response times. The place of the metrics call is linked in the task description and "proof" that it's the only one can be seen here: https://github.com/wikimedia/service-template-node/search?utf8=%E2%9C%93&q=metrics&type= It does not look like the service-runner-template code is going to be easily reusable (without copy&pasting it), as it is indeed meant as a template for new services. It almost looks exactly like the example for the `express/response-time` middleware <https://github.com/expressjs/response-time#response-time-metrics>. The `endTiming` statsd method used in service-runner-template is only a facade to the `timing` method <https://github.com/wikimedia/service-runner/blob/master/lib/statsd.js#L58> seen in the example. This tempts me to try and implement this using the `repsonse-time` middleware. TASK DETAIL https://phabricator.wikimedia.org/T226627 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE Cc: Tarrow, Aklapper, Jakob_WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
