Pablo-WMDE added a comment.

  The cons for strategy 2 are undeniable and substantial - the idea of 
"everything should be part of the href", however, was blown a bit out of 
proportion in the cause of the discussion. It could be the end game but it's 
usefulness is limited until the wikidata side actually makes use of these 
incoming values. Data attributes can be a viable option for augmenting the 
mark-up with needed information that we decide (temporarily or permanently) not 
to encode into the links. My argument is not in favor of adding yet another 
questionable meta requirement but
  
  - to focus on, especially during the MVP phase, //one// solid way of doing 
things
  - trying not to re-implement native browser behavior with elements not meant 
for that (e.g. click behavior on spans)
  - finding a more elegant solution when roadblocks become evident (2 links in 
one marked-up area) instead of hoping it will work out somehow
  
  The links (item id, property id) already exist, and we want template editors 
- for each of them - to specify additional information (editing flow for now).
  Due to the fact that wiki syntax is used, we will not be able to add data 
attributes directly to the hyperlink elements. However, we can add children to 
the hyperlinks, which then are part of the anchor (see edit pen of the example 
above).
  Given the way HTML works, hyper links can not be nested into each other and 
hyperlinks natively exhibit click behavior.
  If we added the needed data attribute(s) to a child (e.g. a span) of the 
hyperlinks we seem to be able to arrive at most of the pros without any of the 
cons - while leaving the door open for a future migration of parameters to the 
href.
  
  `[https://www.wikidata.org/Q123#P456 <span 
data-data-bridge-edit-flow="overwrite">🖊</span>]`
  
  What do you think? @Lucas_Werkmeister_WMDE @Michael

TASK DETAIL
  https://phabricator.wikimedia.org/T227463

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Lydia_Pintscher, Pablo-WMDE, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to