hoo added a comment.
In T227063#5328194 <https://phabricator.wikimedia.org/T227063#5328194>, @Lucas_Werkmeister_WMDE wrote: >> but strangely UpdateRepoOnMoveJob (more precisely UpdateRepoJob) doesn't fail if it can't edit, it just sends a debug message and act like nothing happened in saveChanges > > More specifically, `saveChanges()` does return `true`/`false` to indicate if everything’s okay, but `run()` ignores the return value and unconditionally returns `true` itself. I don’t know if this was intentional at the time, but I also think it would probably be better to retry such cases (i. e. `return $this->saveChanges( $item, $user );`). But that would also retry on for example sitelink conflicts (other item already has that sitelink), but I guess that's bearable. Why are jobs even being run during read only time? After quickly skimming the job queue code, this shouldn't happen AFAICT, is there a task/ documentation about that? TASK DETAIL https://phabricator.wikimedia.org/T227063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Johan, hoo Cc: hoo, Jc86035, Elitre, Lea_Lacroix_WMDE, Lucas_Werkmeister_WMDE, Aklapper, Addshore, alaa_wmde, Ladsgroup, Marostegui, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, Johan, Luke081515, Wikidata-bugs, aude, TheDJ, Mbch331, Jay8g, Qgil
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
