WMDE-leszek added a comment.
My two cents to the recent discussion: 1. The change https://gerrit.wikimedia.org/r/523176 is interesting, in particular the fact it has been accepted by ULS maintainers. In T222790 <https://phabricator.wikimedia.org/T222790> we've been asking them if the "old" behaviour was intended or a mistake, and haven't got the clear answer from the respective team yet. I also note (as an "interesting" observation, I do not claim it is correct and have no opinion on this whatsoever) that "reverse-interpreting" the changes to the said ULS method I referred to in T222790#5198012 <https://phabricator.wikimedia.org/T222790#5198012> seemed to lead to the conclusion that the "old" behaviour ("fil" included in result) was actually intended (at some point in time). It looks now the Language team might have identified the desired behaviour. In this case it would be great to have an answer posted in T222790 <https://phabricator.wikimedia.org/T222790> a well. Apologies from my side for not mentioning T222790 <https://phabricator.wikimedia.org/T222790> in the task description here, it would have been helpful. 2. Re fixing ULS, and not changing Wikibase. I do not oppose such approach. When this story has been being defined the approach considered was a bit different though. Please bear with me when I try to rephrase the approach to the issue here that I had in mind when writing the task. I do not claim it is better, just bringing it up for your consideration here @Ladsgroup and @alaa_wmde. One could look at Wikibase using ULS as a black box, which provides language codes (and possible other language information). In design terms one could think of the "language information source" interface, which Wikibase knows and uses. There could be multiple services serving as a "language information source" for Wikibase, one based on ULS could be easily imagined. Services like ULS should in my eyes be complete agnostic to the fact there is a software like Wikibase that uses them for the particular need. Wikibase does have its own definition of the "valid/allowed/correct" language code, which, again in my opinion, should stay inside Wikibase, i.e. other services, be it ULS, or anything else should not conform to Wikibase conditions, as they simple couldn't even know they exist. Regardless what "service" is used as a "language information provided" I'd argue Wikibase should not just accept its output but always apply its own filtering etc. The point I am trying to make is that a possible fixing ULS might solve the particular "fil" vs "tl" language code issue but gives no guarantees to Wikibase that similar problem wouldn't arise in the future. Building in a "filter" into Wikibase ,could, in my opinion provide such security. Again, I am not arguing that my perspective on this is the right one. This comment is my retroactive attempt to communicate what we've found out so far in the Termbox work, with the hope it is useful for people working on solving this very task. TASK DETAIL https://phabricator.wikimedia.org/T217770 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: alaa_wmde, Ladsgroup, Tarrow, Addshore, Lydia_Pintscher, Pablo-WMDE, gerritbot, WMDE-leszek, Lea_WMDE, Hanna_Petruschat_WMDE, Aklapper, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
