ArielGlenn added a comment.
Ran the following with old and new code for abstracts:
/usr/bin/php7.2 /srv/mediawiki/multiversion/MWScript.php dumpBackup.php
--wiki=anwiki
/srv/v/mediawiki/php-1.34.0-wmf.15/extensions/ActiveAbstract/includes/AbstractFilter.php
--full --report=1
--output=file:/mnt/dumpsdata/temp/dumpsgen/abstracts-anwiki-cr-testing.txt.test
--filter=noredirect --filter=abstract --skip-header --start=36142
--skip-footer --end 36150
/usr/bin/php7.2 /srv/mediawiki/multiversion/MWScript.php dumpBackup.php
--wiki=enwiki /srv/mediawiki/php-1.34.0-wmf.15
--plugin=AbstractFilter:/srv/mediawiki/php-1.34.0-wmf.15/extensions/ActiveAbstract/includes/AbstractFilter.php
--full --report=1
--output=file:/mnt/dumpsdata/temp/dumpsgen/abstracts-enwiki-cr-testing.txt.prod
--filter=noredirect --filter=abstract --skip-header --start=1240149
--skip-footer --end 1240150
/usr/bin/php7.2 /srv/mediawiki/multiversion/MWScript.php dumpBackup.php
--wiki=dewikiversity /srv/mediawiki/php-1.34.0-wmf.15
--plugin=AbstractFilter:/srv/mediawiki/php-1.34.0-wmf.15/extensions/ActiveAbstract/includes/AbstractFilter.php
--current --report=1
--output=file:/mnt/dumpsdata/temp/dumpsgen/abstracts-dewv-cr-testing.txt.test
--filter=noredirect --filter=abstract --skip-header --start=47279 --skip-footer
--end 47300
The first two have identical output with and without the change.
The last has the following diff:
dumpsgen@snapshot1008:~$ diff
/mnt/dumpsdata/temp/dumpsgen/abstracts-dewv-cr-testing.txt.good
/mnt/dumpsdata/temp/dumpsgen/abstracts-dewv-cr-testing.txt.test
4c4
< <abstract serialization-error="" />
---
> <abstract />
5a6
> <sublink linktype="nav"><anchor>Schulprojekt:Physik Sekundarstufe
I</anchor><link>https://de.wikiversity.org/wiki/Kategorie:Schulprojekt:Physik_Sekundarstufe_I</link></sublink>
I think we can live with the empty tag; some pages produce that already. I
need to look at the link data and see if that makes sense.
TASK DETAIL
https://phabricator.wikimedia.org/T198343
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: ArielGlenn
Cc: ArielGlenn, Aklapper, aude, Anomie, Jdforrester-WMF, Tgr, gerritbot,
daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild,
darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris,
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30,
Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis,
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden,
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper,
Agabi10, Wikidata-bugs, Mbch331, Ltrlg
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs