Daimona closed this task as "Resolved".
Daimona added a comment.
After my patch, we have:
$cfg['suppress_issue_types'][] = 'PhanParamSignatureMismatch';
// False positives with methods taking nullables
$cfg['suppress_issue_types'][] = 'PhanParamReqAfterOpt';
// @todo Remove the next line once HHVM is gone. Many instances are on
ArrayObjects, and on HHVM the
// coalesce operator doesn't behave well on them.
$cfg['suppress_issue_types'][] =
'PhanPluginDuplicateConditionalNullCoalescing';
The former is to avoid tons of false positives, ditto for the second, and the
third one is HHVM-only, so calling this resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T226254
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Aklapper, alaa_wmde, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86,
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas,
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
