alaa_wmde added a comment.
This doesn't fix the issue. When testing the updated script with
double-redirects, it still failed due to the actual exceptipon being thrown is
`ItemLookupException` and not `RevisionedUnresolvedRedirectException`.
Wikibase\DataModel\Services\Lookup\ItemLookupException from line 33 of
/var/www/mediawiki/vendor/wikibase/data-model-services/src/Lookup/LegacyAdapterItemLookup.php:
Unresolved redirect from Q2428 to Q2429
#0
/var/www/mediawiki/extensions/Wikibase/repo/includes/Store/ItemTermsRebuilder.php(109):
Wikibase\DataModel\Services\Lookup\LegacyAdapterItemLookup->getItemForId(Object(Wikibase\DataModel\Entity\ItemId))
#1
/var/www/mediawiki/extensions/Wikibase/repo/includes/Store/ItemTermsRebuilder.php(73):
Wikibase\Repo\Store\ItemTermsRebuilder->rebuildTermsForBatch(Array)
#2
/var/www/mediawiki/extensions/Wikibase/repo/maintenance/rebuildItemTerms.php(84):
Wikibase\Repo\Store\ItemTermsRebuilder->rebuild()
#3 /var/www/mediawiki/maintenance/doMaintenance.php(99):
Wikibase\RebuildItemTerms->execute()
#4
/var/www/mediawiki/extensions/Wikibase/repo/maintenance/rebuildItemTerms.php(123):
require_once('/var/www/mediaw...')
#5 {main}
Wikibase\Lib\Store\RevisionedUnresolvedRedirectException from line 152 of
/var/www/mediawiki/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php:
Unresolved redirect from Q2428 to Q2429
#0
/var/www/mediawiki/extensions/Wikibase/lib/includes/Store/DispatchingEntityRevisionLookup.php(59):
Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->getEntityRevision(Object(Wikibase\DataModel\Entity\ItemId),
0, 'replica')
#1
/var/www/mediawiki/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityRevisionLookup.php(54):
Wikibase\Lib\Store\DispatchingEntityRevisionLookup->getEntityRevision(Object(Wikibase\DataModel\Entity\ItemId),
0, 'replica')
#2
/var/www/mediawiki/extensions/Wikibase/lib/includes/Store/CacheRetrievingEntityRevisionLookup.php(75):
Wikibase\Lib\Store\TypeDispatchingEntityRevisionLookup->getEntityRevision(Object(Wikibase\DataModel\Entity\ItemId),
0, 'replica')
#3
/var/www/mediawiki/extensions/Wikibase/lib/includes/Store/RevisionBasedEntityLookup.php(39):
Wikibase\Lib\Store\CacheRetrievingEntityRevisionLookup->getEntityRevision(Object(Wikibase\DataModel\Entity\ItemId))
#4
/var/www/mediawiki/extensions/WikibaseLexeme/vendor/wikibase/data-model-services/src/Lookup/RedirectResolvingEntityLookup.php(53):
Wikibase\Lib\Store\RevisionBasedEntityLookup->getEntity(Object(Wikibase\DataModel\Entity\ItemId))
#5
/var/www/mediawiki/vendor/wikibase/data-model-services/src/Lookup/LegacyAdapterItemLookup.php(31):
Wikibase\DataModel\Services\Lookup\RedirectResolvingEntityLookup->getEntity(Object(Wikibase\DataModel\Entity\ItemId))
#6
/var/www/mediawiki/extensions/Wikibase/repo/includes/Store/ItemTermsRebuilder.php(109):
Wikibase\DataModel\Services\Lookup\LegacyAdapterItemLookup->getItemForId(Object(Wikibase\DataModel\Entity\ItemId))
#7
/var/www/mediawiki/extensions/Wikibase/repo/includes/Store/ItemTermsRebuilder.php(73):
Wikibase\Repo\Store\ItemTermsRebuilder->rebuildTermsForBatch(Array)
#8
/var/www/mediawiki/extensions/Wikibase/repo/maintenance/rebuildItemTerms.php(84):
Wikibase\Repo\Store\ItemTermsRebuilder->rebuild()
#9 /var/www/mediawiki/maintenance/doMaintenance.php(99):
Wikibase\RebuildItemTerms->execute()
#10
/var/www/mediawiki/extensions/Wikibase/repo/maintenance/rebuildItemTerms.php(123):
require_once('/var/www/mediaw...')
#11 {main}
Suggestion here:
- catch `ItemLookupException` and report to output those items that fail to
rebuild (with exception msg); or
- fail on all exception so that we fix or decide what to do case-by-case
TASK DETAIL
https://phabricator.wikimedia.org/T229816
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup, alaa_wmde
Cc: Lydia_Pintscher, WMDE-leszek, alaa_wmde, Aklapper, Ladsgroup,
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,
LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
