LucasWerkmeister added a comment.
I don’t think implementing `TermIndex` itself, as the linked change currently does, is a good idea. It’s not a great interface (combining lookup, search and modification), and for the new term store in Wikibase we did not write a new implementation of it, but instead implementations of several different interfaces – so I would be wary of any code that really needs a `TermIndex` (because that would likely be broken on Wikidata already as we migrate away from `wb_terms`). I think what you need to implement for WikibaseMediaInfo Lua support is `PrefetchingTermLookup` – implementing `TermIndex` gets you that (via `BufferingTermLookup`), but it would be better to do it directly. @matthiasmullie I hear you’re also in Stockholm, so we can also discuss this in person if you want :) TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: LucasWerkmeister Cc: LucasWerkmeister, jleedev, MarkTraceur, Yann, Addshore, Smalyshev, Mholloway, matthiasmullie, Multichill, Marsupium, Keegan, Jheald, Mike_Peel, Cparle, Aklapper, Jarekt, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Edtadros, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, Ramsey-WMF, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Salgo60, WSH1906, Lewizho99, Maathavan, Silverfish, _jensen, rosalieper, Morgankevinj, Susannaanas, Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
